[jsword-devel] AccuracyType problems, question

[DM Smith]

Phillip,
The patch applied cleanly and your JUnit tests ran with no problem! Many 
thanks! The problems that you are encountering should be fixed in the 
next day or two. I think the code under svn is broken at the moment. I 
need to check in your changes as well as a few others and it will be fixed.
We have an ant task for checkstyle and we have custom formatting and 
code rules for Eclipse that we use to govern coding conventions. I'll 
run these prior to checkin and make the suggested changes. I'll let you 
know if there were any, but from a glance it looked good. And having the 
new method was an excellent add.

Thanks again,
DM


P. R. B. wrote:
> Thanks!
>
> I was unable to sign up on the bugs page (the signon form submitted, 
> but didn't return or timeout), so I've attached the zipped patch and 
> JUnit here. Also, after grabbing the versification changes, BibleInfo 
> and BibleNames seem to have some problems that cause my tests to fail 
> after patching. I'm new to SVN, so it's possible that I didn't pick up 
> all the changes (Using an Eclipse SVN plug-in, I assume using the 
> "update" function with a project selected means that it will update 
> all the files in the project).
>
> Here's a repeat of what the patch fixes:
>
> There's a for loop in AccuracyType.fromText(String, String[], 
> AccuracyType, VerseRange) that doesn't use its index when building the 
> NoSuchVerseException
> (the array is always referenced at index 1). For parts.length == 1, 
> this causes an ArrayIndexOutOfBoundsException, for parts.length >= 3, 
> this produces an invalid message in the exception.
> This patch moves the exception-building process into its own static 
> method.
>
> The solution is "correct," but it may not fit the JSword coding 
> conventions. If it doesn't, please let me know so I can accommodate 
> future changes.
>
> Thanks,
> -Phillip
>
>
>
>
> */DM Smith <dmsmith555 at yahoo.com>/* wrote:
>
>     Phillip,
>
>     Thanks! And welcome to JSword!
>
>     Yes, zip it and post it here. Or join the bugs database at
>     www.crosswire.org/bugs <http://www.crosswire.org/bugs> and post a
>     bug against JSword and attach the patch and junit there. No need
>     to zip attachments there, but it is OK to do so.
>
>     In His Service,
>     DM Smith
>
>     On Oct 2, 2006, at 10:08 PM, P. R. B. wrote:
>
>>     Hello,
>>
>>     I noticed a for loop in AccuracyType.fromText(String, String[],
>>     AccuracyType, VerseRange) that doesn't use its index when
>>     building the NoSuchVerseException
>>     (the array is always referenced at index 1). For parts.length ==
>>     1, this causes an ArrayIndexOutOfBoundsException, for
>>     parts.length >= 3, this produces an invalid message in the
>>     exception.
>>
>>     I have a SVN patch for it with a corresponding JUnit class.
>>     Assuming this problem isn't a known issue, is this patch
>>     something worth contributing? If so, should these be zipped and
>>     posted here or elsewhere?
>>
>>     Thanks,
>>     -Phillip
>>
>>
>>     ------------------------------------------------------------------------
>>     How low will we go? Check out Yahoo! Messenger’s low PC-to-Phone
>>     call rates.
>>     <http://us.rd.yahoo.com/mail_us/taglines/postman8/*http://us.rd.yahoo.com/evt=39663/*http://voice.yahoo.com>
>>
>>     _______________________________________________
>>     jsword-devel mailing list
>>     jsword-devel at crosswire.org <mailto:jsword-devel at crosswire.org>
>>     http://www.crosswire.org/mailman/listinfo/jsword-devel
>
>     _______________________________________________
>     jsword-devel mailing list
>     jsword-devel at crosswire.org
>     http://www.crosswire.org/mailman/listinfo/jsword-devel
>
>
> ------------------------------------------------------------------------
> Get your own web address for just $1.99/1st yr 
> <%20http://us.rd.yahoo.com/evt=43290/*http://smallbusiness.yahoo.com/domains>. 
> We'll help. Yahoo! Small Business 
> <http://us.rd.yahoo.com/evt=41244/*http://smallbusiness.yahoo.com/>.
> ------------------------------------------------------------------------
>
> _______________________________________________
> jsword-devel mailing list
> jsword-devel at crosswire.org
> http://www.crosswire.org/mailman/listinfo/jsword-devel
>